This is an automated email from the ASF dual-hosted git repository. voonhous pushed a commit to tag rfc-105-pre-cleanup in repository https://gitbox.apache.org/repos/asf/hudi.git
commit 0e58d4b79984068724079bb95e921554dc8c2243 Author: voon <[email protected]> AuthorDate: Wed May 27 19:47:50 2026 +0800 todo(trino): mark LIMIT pushdown as a follow-up Adds TODO markers in TestHudiConnectorTest (next to the SUPPORTS_LIMIT_PUSHDOWN=false declaration) and on HudiMetadata so future work to support applyLimit and short-circuit split listing in HudiSplitSource is discoverable from both ends. --- hudi-trino-plugin/src/main/java/io/trino/plugin/hudi/HudiMetadata.java | 3 +++ .../src/test/java/io/trino/plugin/hudi/TestHudiConnectorTest.java | 1 + 2 files changed, 4 insertions(+) diff --git a/hudi-trino-plugin/src/main/java/io/trino/plugin/hudi/HudiMetadata.java b/hudi-trino-plugin/src/main/java/io/trino/plugin/hudi/HudiMetadata.java index 9f49718f77ba..b959e6dac679 100644 --- a/hudi-trino-plugin/src/main/java/io/trino/plugin/hudi/HudiMetadata.java +++ b/hudi-trino-plugin/src/main/java/io/trino/plugin/hudi/HudiMetadata.java @@ -107,6 +107,9 @@ import static org.apache.hudi.common.table.timeline.HoodieTimeline.DELTA_COMMIT_ import static org.apache.hudi.common.table.timeline.HoodieTimeline.INDEXING_ACTION; import static org.apache.hudi.common.table.timeline.HoodieTimeline.REPLACE_COMMIT_ACTION; +// TODO: implement applyLimit(...) to push LIMIT into HudiTableHandle so the split loader can +// short-circuit partition/file-slice listing once a row-count estimate covers the limit. +// Also flip SUPPORTS_LIMIT_PUSHDOWN to true in TestHudiConnectorTest once implemented. public class HudiMetadata implements ConnectorMetadata { diff --git a/hudi-trino-plugin/src/test/java/io/trino/plugin/hudi/TestHudiConnectorTest.java b/hudi-trino-plugin/src/test/java/io/trino/plugin/hudi/TestHudiConnectorTest.java index 0aa6e0eaa733..d1a1460a2ed3 100644 --- a/hudi-trino-plugin/src/test/java/io/trino/plugin/hudi/TestHudiConnectorTest.java +++ b/hudi-trino-plugin/src/test/java/io/trino/plugin/hudi/TestHudiConnectorTest.java @@ -49,6 +49,7 @@ public class TestHudiConnectorTest SUPPORTS_DELETE, SUPPORTS_DEREFERENCE_PUSHDOWN, SUPPORTS_INSERT, + // TODO: implement LIMIT pushdown in HudiMetadata.applyLimit and flip this on. SUPPORTS_LIMIT_PUSHDOWN, SUPPORTS_MERGE, SUPPORTS_RENAME_COLUMN,
