danny0405 commented on code in PR #18877:
URL: https://github.com/apache/hudi/pull/18877#discussion_r3385534656
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/storage/row/HoodieRowDataCreateHandle.java:
##########
@@ -122,7 +123,7 @@ public HoodieRowDataCreateHandle(HoodieTable table,
HoodieWriteConfig writeConfi
table.getPartitionMetafileFormat());
partitionMetadata.trySave();
createMarkerFile(partitionPath,
FSUtils.makeBaseFileName(this.instantTime, getWriteToken(), this.fileId,
table.getBaseFileExtension()));
- this.fileWriter = createNewFileWriter(path, table, writeConfig, rowType,
this.instantTime);
Review Comment:
if rowType is not used, can we pass around the schema explicitly instead ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]