danny0405 commented on code in PR #18877:
URL: https://github.com/apache/hudi/pull/18877#discussion_r3385549557
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/catalog/HoodieCatalog.java:
##########
@@ -319,9 +320,12 @@ public void createTable(ObjectPath tablePath,
CatalogBaseTable catalogTable, boo
&& !OptionsResolver.isAppendMode(conf)) {
throw new CatalogException("Primary key definition is missing");
}
+ LogicalType rowType =
resolvedSchema.toPhysicalRowDataType().getLogicalType();
+ HoodieSchemaConverter.validateVectorColumns(rowType,
conf.get(FlinkOptions.VECTOR_COLUMNS));
final String avroSchema = HoodieSchemaConverter.convertToSchema(
Review Comment:
move the validateVectorColumns inside HoodieSchemaConverter.convertToSchema
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
