cshuo commented on code in PR #18877:
URL: https://github.com/apache/hudi/pull/18877#discussion_r3395795940
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/storage/row/parquet/ParquetRowDataWriter.java:
##########
@@ -97,7 +106,8 @@ public void write(final RowData record) {
recordConsumer.endMessage();
}
- private FieldWriter createWriter(LogicalType t) {
+ private FieldWriter createWriter(LogicalType t, HoodieSchema fieldSchema) {
+ HoodieSchema resolvedSchema = fieldSchema.getNonNullType();
Review Comment:
fixed.
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/storage/row/HoodieRowDataCreateHandle.java:
##########
@@ -122,7 +123,7 @@ public HoodieRowDataCreateHandle(HoodieTable table,
HoodieWriteConfig writeConfi
table.getPartitionMetafileFormat());
partitionMetadata.trySave();
createMarkerFile(partitionPath,
FSUtils.makeBaseFileName(this.instantTime, getWriteToken(), this.fileId,
table.getBaseFileExtension()));
- this.fileWriter = createNewFileWriter(path, table, writeConfig, rowType,
this.instantTime);
Review Comment:
fixed.
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/storage/row/HoodieRowDataFileWriterFactory.java:
##########
@@ -124,7 +124,7 @@ public HoodieFileWriter newLanceFileWriter(
boolean withOperation =
config.getBooleanOrDefault(HoodieWriteConfig.ALLOW_OPERATION_METADATA_FIELD);
Option<org.apache.hudi.common.bloom.BloomFilter> bloomFilter =
enableBloomFilter(populateMetaFields, config)
? Option.of(createBloomFilter(config)) : Option.empty();
- RowType rowType = HoodieSchemaConverter.convertToRowType(schema);
+ RowType rowType = (RowType)
HoodieSchemaConverter.convertToDataType(schema).getLogicalType();
Review Comment:
reverted.
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/storage/row/parquet/ParquetRowDataWriter.java:
##########
@@ -66,14 +71,18 @@ public ParquetRowDataWriter(
RecordConsumer recordConsumer,
RowType rowType,
GroupType schema,
- boolean utcTimestamp) {
+ boolean utcTimestamp,
+ HoodieSchema hoodieSchema) {
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
