wombatu-kun commented on code in PR #18957:
URL: https://github.com/apache/hudi/pull/18957#discussion_r3407417303
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/HoodieTableFileSystemView.java:
##########
@@ -89,6 +88,7 @@ public class HoodieTableFileSystemView extends
IncrementalTimelineSyncFileSystem
/**
* Flag to determine if closed.
*/
+ @Getter
Review Comment:
`@Getter` here is a no-op: `isClosed()` is still defined explicitly at line
458, and Lombok skips generation when a same-name method already exists. The
sibling `RocksDbBasedFileSystemView` removed its explicit `isClosed()` and kept
only `@Getter(AccessLevel.PACKAGE)`. For consistency and to actually drop the
boilerplate, remove the explicit `isClosed()` (lines 458-460) - it returns
`closed` as `public`, matching Lombok's default `@Getter` output - or drop this
annotation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
