voonhous commented on code in PR #18957: URL: https://github.com/apache/hudi/pull/18957#discussion_r3407604260
########## hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v1/ActiveTimelineV1.java: ########## @@ -62,6 +62,8 @@ import static org.apache.hudi.common.table.timeline.TimelineUtils.getHoodieInstantWriterOption; +@NoArgsConstructor Review Comment: Good catch. Switched both `ActiveTimelineV1` and `ActiveTimelineV2` to `@NoArgsConstructor(onConstructor_ = @Deprecated)`, which keeps the generated no-arg constructor `@Deprecated` (so callers still get the deprecation warning) and consistent with the still-`@Deprecated` `readObject` below, while staying within the Lombok-ification of this PR. Added a short inline comment to retain the "for serialization and de-serialization only" rationale that the original Javadoc carried. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
