voonhous commented on code in PR #18957: URL: https://github.com/apache/hudi/pull/18957#discussion_r3407604260
########## hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v1/ActiveTimelineV1.java: ########## @@ -62,6 +62,8 @@ import static org.apache.hudi.common.table.timeline.TimelineUtils.getHoodieInstantWriterOption; +@NoArgsConstructor Review Comment: Good catch. Reverted to the explicit hand-written constructor in both `ActiveTimelineV1` and `ActiveTimelineV2`, which preserves the `@Deprecated` marker (and the deprecation warning for callers) along with the "For serialization and de-serialization only." Javadoc, keeping it consistent with the still-`@Deprecated` `readObject` below. I went with the explicit constructor rather than `@NoArgsConstructor(onConstructor_ = @Deprecated)` since the latter would still drop the explanatory Javadoc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
