wombatu-kun commented on code in PR #18805:
URL: https://github.com/apache/hudi/pull/18805#discussion_r3408877351
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/common/config/DFSPropertiesConfiguration.java:
##########
@@ -156,8 +156,8 @@ public void addPropsFromFile(StoragePath filePath) {
);
try {
- if (filePath.equals(DEFAULT_PATH) && !storage.exists(filePath)) {
- log.debug("Properties file {} not found. Ignoring to load props file",
filePath);
+ if (!storage.exists(filePath)) {
Review Comment:
The narrow DEFAULT_PATH gate was intentional - #4167 added it so only the
optional global-defaults file is silently skippable. The top-level entry points
that lose fail-fast here are UtilHelpers.readConfig (UtilHelpers.java:259) and
StreamerUtil.readConfig (StreamerUtil.java:186), each passing a user --props
path straight into the constructor. Scoping the skip to the include= recursion
at addPropsFromStream (line 198) preserves fail-fast for explicit top-level
paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
