voonhous commented on code in PR #13147:
URL: https://github.com/apache/hudi/pull/13147#discussion_r3584589117


##########
hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/RequestHandler.java:
##########
@@ -242,6 +258,43 @@ private void registerTimelineAPI() {
     }, false));
   }
 
+  /**
+   * Register v2 Timeline API calls used by the Timeline UI. Gated behind 
--enable-ui.
+   */
+  private void registerTimelineV2API() {
+    app.get(RemoteHoodieTableFileSystemView.TIMELINE_V2_URL, new 
ViewHandler(ctx -> {
+      metricsRegistry.add("TIMELINE_V2", 1);
+      TimelineDTOV2 dto = instantHandler.getTimelineV2(getBasePathParam(ctx));
+      writeValueAsString(ctx, dto);
+    }, false));
+
+    app.get(RemoteHoodieTableFileSystemView.INSTANT_DETAILS_URL, new 
ViewHandler(ctx -> {
+      metricsRegistry.add("INSTANT_DETAILS", 1);
+      Object instantDetails = 
instantHandler.getInstantDetails(getBasePathParam(ctx),
+          getInstantParam(ctx), getInstantActionParam(ctx), 
getInstantStateParam(ctx));
+      writeValueAsString(ctx, instantDetails);
+    }, false));
+
+    app.get(RemoteHoodieTableFileSystemView.TABLE_CONFIG_V2_URL, new 
ViewHandler(ctx -> {
+      metricsRegistry.add("TABLE_CONFIG", 1);
+      writeValueAsString(ctx, 
instantHandler.getTableConfig(getBasePathParam(ctx)));
+    }, false));
+
+    app.get(RemoteHoodieTableFileSystemView.SCHEMA_HISTORY_V2_URL, new 
ViewHandler(ctx -> {
+      metricsRegistry.add("SCHEMA_HISTORY", 1);
+      int limit;

Review Comment:
   Addressed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to