voonhous commented on code in PR #13147: URL: https://github.com/apache/hudi/pull/13147#discussion_r3589192970
########## scripts/release/validate_bundle_ui_assets.sh: ########## @@ -0,0 +1,152 @@ +#!/bin/bash + +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# +# Guards the "public/**" shade exclusions added for the Hudi Timeline UI (RFC-94). +# The Timeline UI assets (vis-timeline, Bootstrap, renderjson) must ship ONLY in +# hudi-timeline-server-bundle. The five engine bundles exclude "public/**" so that +# the bundled-library LICENSE obligations stay scoped to the server bundle. RFC-94 +# calls this negative assertion load-bearing: without it the exclusion can regress Review Comment: Wired it into the three `validate-bundles*` jobs in `bot.yml`, right after **Build Project** -- that is where built jars actually exist (`packaging/*/target/`, the script's default search dir). The scala-2.12 legs do a full build, so the positive server-bundle assertion runs there too. Skipped `validate_staged_release.sh`: it only checks the source tarball (checksums, GPG, RAT) and never builds jars, so the check would be a permanent no-op there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
