voonhous commented on code in PR #13147:
URL: https://github.com/apache/hudi/pull/13147#discussion_r3592817719
##########
hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/TimelineService.java:
##########
@@ -230,17 +238,35 @@ private void createApp() {
ScheduledExecutorScheduler scheduler = new
ScheduledExecutorScheduler("TimelineService-JettyScheduler", true, 8);
server.addBean(scheduler);
+ if (timelineServerConf.enableUi &&
TimelineService.class.getResource("/public/index.html") == null) {
Review Comment:
Fixed -- moved the check to the top of `startServiceOnPort`, next to the
existing port-range precondition, so it throws once with the actionable message
instead of being swallowed by the retry loop. `createApp()` no longer has the
guard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
