voonhous opened a new pull request, #19410:
URL: https://github.com/apache/hudi/pull/19410

   No release path built or staged org.apache.hudi:hudi-trino: the existing 
staging scripts require JDK 11 and JDK 17, neither passes -Phudi-trino, and the 
legacy hudi-trino-bundle was dropped in #18837, while the Trino-side shim 
depends on this artifact, so it must be staged with the first 1.3.0 RC.
   
   - deploy_staging_jars_java25.sh mirrors the java17 script but runs a single 
pass, mvn deploy -Phudi-trino -pl hudi-trino, without -am: Lombok cannot run on 
JDK 25, so the upstream Hudi modules resolve from the local m2 populated by the 
prior deploy_staging_jars.sh (JDK 11) run.
   - hudi-trino/pom.xml overrides the release profile's javadoc source level 
(pinned to 11 by the root pom) to hudi.trino.java.version. At source 11, 
javadoc errors on records and unnamed variables, and failOnError=false turns 
that into a silently broken -javadoc.jar in the staging repo.
   - validate_staged_bundles.sh now checks org.apache.hudi:hudi-trino across 
all 16 jar/sources/javadoc/pom + signature/checksum extensions.
   - release_guide.md documents the JDK 25 deploy step (deploy3 log) and the 
extra copy_staging_repo.sh pass for the JDK 25 staging repo.
   - The source tarball needs no change: create_source_directory.sh rsyncs the 
full git clone, so hudi-trino/ ships regardless of the profile. A stale bot.yml 
comment citing the removed hudi-trino-plugin RAT exclude is reworded.
   
   Verified locally: upstream modules installed under JDK 17, then a clean mvn 
install -Phudi-trino -pl hudi-trino -DdeployArtifacts=true -Dgpg.skip under JDK 
25 produces the main, sources, and javadoc jars, with record classes 
documented; without the pom override the javadoc jar is broken.
   
   Fixes #19346
   
   ### Describe the issue this Pull Request addresses
   
   <!-- Either describe the issue inline here with motivation behind the 
changes 
        (or) link to an issue by including `Closes #<issue-number>` for 
context. 
        If this PR includes changes to the storage format, public APIs,
        or has breaking changes, use `!` (e.g., feat!: ...) -->
   
   ### Summary and Changelog
   
   <!-- Short, plain-English summary of what users gain or what changed in 
behavior.
        Followed by a detailed log of all the changes. Highlight if any code 
was copied. -->
   
   ### Impact
   
   <!-- Describe any public API or user-facing feature change or any 
performance impact. -->
   
   ### Risk Level
   
   <!-- Accepted values: none, low, medium or high. Other than `none`, explain 
the risk.
        If medium or high, explain what verification was done to mitigate the 
risks. -->
   
   ### Documentation Update
   
   <!-- Describe any necessary documentation update if there is any new 
feature, config, or user-facing change. If not, put "none".
   
   - The config description must be updated if new configs are added or the 
default value of the configs are changed.
   - Any new feature or user-facing change requires updating the Hudi website. 
Please follow the 
     [instruction](https://hudi.apache.org/contribute/developer-setup#website) 
to make changes to the website. -->
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Enough context is provided in the sections above
   - [ ] Adequate tests were added if applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to