hudi-agent commented on code in PR #19410:
URL: https://github.com/apache/hudi/pull/19410#discussion_r3674740151
##########
hudi-trino/pom.xml:
##########
@@ -595,6 +595,14 @@
<annotationProcessorPaths combine.self="override"/>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-javadoc-plugin</artifactId>
+ <configuration>
+ <!-- The parent release profile pins javadoc source to 11;
records need 25. -->
+ <source>${hudi.trino.java.version}</source>
Review Comment:
🤖 Have you confirmed the effective javadoc source is actually 25 during the
release deploy? The `<source>` here lives in the module's base build, while the
pin to 11 comes from the parent's property-activated `release` profile. Child
build config should win over an inherited-profile config, but since
`failOnError=false` turns a wrong value into a silently broken `-javadoc.jar`
and `validate_staged_bundles.sh` only checks the jar exists (not that it's
valid), it'd be reassuring to verify via `mvn help:effective-pom
-DdeployArtifacts=true -pl hudi-trino` that the resolved javadoc source is 25.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
