voonhous commented on code in PR #19410:
URL: https://github.com/apache/hudi/pull/19410#discussion_r3679876850
##########
.github/workflows/bot.yml:
##########
@@ -87,8 +87,11 @@ jobs:
#
# Stage the copy outside the workspace. `mvn apache-rat:check` in the
RAT check step scans
# the filesystem from the repository root, so a copy of the tree left
inside the workspace
- # gets scanned too, and every root-anchored exclude in the root pom
(such as
- # `hudi-trino-plugin/**`) silently stops applying to it.
+ # gets scanned too, and every root-anchored exclude in the root pom
(such as `.github/**`)
+ # silently stops applying to it.
+ #
+ # hudi-trino needs no RAT exclude: its files carry AL headers that RAT
accepts, and its
+ # Trino-style license checks are handled by airlift.
Review Comment:
Good catch, the clause was stale. It **was** true before RFC-105:
`hudi-trino-plugin` was parented to `io.trino:trino-root`, whose airbase parent
binds `com.mycila:license-maven-plugin` into every build. #18837 re-parented
the module to the Hudi root pom, so nothing in this repo runs that check
anymore.
Reworded the comment to point at the upstream trinodb/trino build. The RAT
half stands: all `hudi-trino` files carry the short AL header, which RAT's
default matchers accept.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
