voonhous commented on code in PR #19455:
URL: https://github.com/apache/hudi/pull/19455#discussion_r3698319861


##########
hudi-spark-datasource/hudi-spark3.5.x/src/main/scala/org/apache/spark/sql/parser/HoodieSpark3_5ExtendedSqlAstBuilder.scala:
##########
@@ -1044,8 +1000,6 @@ class HoodieSpark3_5ExtendedSqlAstBuilder(conf: SQLConf, 
delegate: ParserInterfa
         SerdeInfo(storedAs = Some(c.identifier.getText))
       case (null, storageHandler) =>

Review Comment:
   Addressed in 9f6cd85f5966: the comment now states the `ROW FORMAT ... STORED 
BY` reachability reason, and both arms are covered in `TestBlobDataType` -- 
`blob_ff7` (`ROW FORMAT SERDE` + `STORED AS INPUTFORMAT/OUTPUTFORMAT`) and 
`blob_ferr5` asserting the `Unexpected combination of` rejection.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to