voonhous commented on code in PR #19455:
URL: https://github.com/apache/hudi/pull/19455#discussion_r3698531706


##########
hudi-spark-datasource/hudi-spark3.3.x/src/main/scala/org/apache/spark/sql/parser/HoodieSpark3_3ExtendedSqlAstBuilder.scala:
##########
@@ -1277,7 +1244,7 @@ class HoodieSpark3_3ExtendedSqlAstBuilder(conf: SQLConf, 
delegate: ParserInterfa
     // partition transforms for BucketSpec was moved inside parser
     // https://issues.apache.org/jira/browse/SPARK-37923
     val partitioning =
-      partitionExpressions(partTransforms, partCols, ctx) ++ 
bucketSpec.map(_.asTransform)
+    partitionExpressions(partTransforms, partCols, ctx) ++ 
bucketSpec.map(_.asTransform)

Review Comment:
   Fixed in 251e81b6d06d -- and the direction is flipped per your point: the 
3.3 copy was the one matching upstream Spark's `AstBuilder`, so all six 
builders now use the 6-space continuation instead of flattening 3.3 to match 
the drifted five.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to