wombatu-kun commented on code in PR #19455:
URL: https://github.com/apache/hudi/pull/19455#discussion_r3698355364
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/schema/TestBlobDataType.scala:
##########
@@ -485,6 +484,18 @@ class TestBlobDataType extends HoodieSparkSqlTestBase with
ExtendedParserTestHel
firstLiteralArg(transformByName(plan, "mu_ivl_t")).dataType)
assertResult(YearMonthIntervalType(YearMonthIntervalType.YEAR,
YearMonthIntervalType.MONTH))(
firstLiteralArg(transformByName(plan, "uu_ivl_t")).dataType)
+
+ // Under ANSI keyword mode a bare false must survive visitBooleanLiteral
as a typed literal,
+ // while a bare true stays a column reference (TRUE is ansiNonReserved,
FALSE is not).
+ withSQLConf("spark.sql.ansi.enabled" -> "true") {
Review Comment:
`visitNullLiteral` is kept on the same ANSI-reachability argument as
`visitBooleanLiteral`, but only the boolean case gets a scaladoc note and a
regression assertion. Worth adding a `null_t(null, id)` transform to this ANSI
block asserting `NullType`, so the next pruning pass cannot silently delete
that visitor either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
