linliu-code commented on code in PR #681:
URL: https://github.com/apache/hudi-rs/pull/681#discussion_r3793143393
##########
.github/workflows/ci.yml:
##########
@@ -105,6 +105,15 @@ jobs:
run: cargo clippy -p hudi-core --lib --no-default-features -- -D
warnings
- name: Unit tests without the spill backend
run: cargo test -p hudi-core --lib --no-default-features --no-fail-fast
+ # The umbrella crate is where a consumer actually opts out, and it
reaches
+ # hudi-core twice: directly, and through hudi-datafusion. Either edge
taking
+ # default features hands the tier back without the steps above noticing,
+ # since they only build hudi-core. Both shapes are built here, where
there
+ # is no libclang to build rocksdb with.
+ - name: Check the umbrella crate without the spill backend
Review Comment:
These rely on rocksdb's build script failing without libclang, same as the
hudi-core steps above. Might be worth confirming on the first run that a
deliberately re-coupled build does fail here, so we know the gate bites rather
than assuming it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
