linliu-code commented on PR #681: URL: https://github.com/apache/hudi-rs/pull/681#issuecomment-5310348202
Thanks for working on this. This makes the `spill-rocksdb` opt-out actually reachable, since the umbrella crate was handing the tier back regardless of what a consumer asked for. Verified the whole feature matrix with `cargo tree -i rocksdb`: defaults have it, `--features datafusion` has it via both edges, and both `--no-default-features` shapes drop it. `hudi-cpp` and `hudi-python` still compile and still carry the tier, so the wheel and bridge are unaffected. Two questions inline rather than objections. Net-positive as it stands. One review pass, not an approval. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
