linliu-code commented on code in PR #681:
URL: https://github.com/apache/hudi-rs/pull/681#discussion_r3793142770
##########
crates/hudi/Cargo.toml:
##########
@@ -28,10 +28,21 @@ homepage.workspace = true
repository.workspace = true
[dependencies]
-hudi-core = { version = "0.5.0-dev", path = "../core" }
-hudi-datafusion = { version = "0.5.0-dev", path = "../datafusion", optional =
true }
+hudi-core = { version = "0.5.0-dev", path = "../core", default-features =
false }
+hudi-datafusion = { version = "0.5.0-dev", path = "../datafusion", optional =
true, default-features = false }
[features]
+default = ["spill-rocksdb"]
Review Comment:
Since `hudi` had no features before this, `default-features = false` was
previously a no-op and callers still got the spill tier via hudi-core. Now it
drops the tier, so a merge past `hoodie.memory.merge.max.size` errors instead
of spilling. Worth a line in the 0.5.0 changelog for anyone already setting
that flag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
