hudi-agent commented on code in PR #19648:
URL: https://github.com/apache/hudi/pull/19648#discussion_r3817100406
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/keygen/PartitionPathFormatterBase.java:
##########
@@ -75,15 +75,11 @@ public final S combine(List<String> partitionPathFields,
Object... partitionPath
if (useHiveStylePartitioning) {
Review Comment:
🤖 Confirmed against the Avro side: both `KeyGenUtils.getRecordPartitionPath`
(the `size()==1 && slashSeparatedDatePartitioning` branch, ~L257-262) and
`getPartitionPath` (~L291-295) run `replace('-', '/')` *after* prepending the
`field=` hive prefix, so the Avro path really does produce
`date_col=2026/01/05`. The row-writer `combine` only slashes in the non-hive
branches, so hive-style + slash + single-field diverges to
`date_col=2026-01-05`. Agree it's pre-existing and fine to align in a
follow-up, but it'd be worth not pinning the divergent result in
`testHiveStylePartitioningTakesPrecedence` so the follow-up doesn't have to
rewrite the assertion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
