SEPURI-SAI-KRISHNA commented on code in PR #19648:
URL: https://github.com/apache/hudi/pull/19648#discussion_r3818374749
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/keygen/PartitionPathFormatterBase.java:
##########
@@ -75,15 +75,11 @@ public final S combine(List<String> partitionPathFields,
Object... partitionPath
if (useHiveStylePartitioning) {
Review Comment:
Thanks for tracing the Avro side — that matches what I found, and the
divergence is tracked in #19669.
On not pinning the assertion: I'd like to keep it. The test exists
specifically to characterize the current row-writer behavior, and the NOTE
above it already says so explicitly ("This asserts the pre-existing behavior
stays put, it is not a statement about what the combination *should* produce").
Without the assertion the test has nothing left to check. And a follow-up
having to update this line is the useful signal rather than a cost — it makes
the behavior change visible in that PR's diff instead of silent.
Worth adding that it isn't obvious the row writer is the side that's wrong
here: the Avro path's `date_col=2026/01/05` is a layout
`HoodieSparkUtils#doParsePartitionColumnValues` cannot read back, so #19669 may
well settle on the row writer's current output as the correct one. Pinning it
now keeps that option open.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
