OjashKush opened a new pull request, #19882:
URL: https://github.com/apache/hudi/pull/19882
HudiTrinoStorage is registered at Hudi's pluggable-storage extension point
but cannot be constructed through it.
TrinoStorageConfiguration.getDefaultConfigs() sets HOODIE_STORAGE_CLASS to
HudiTrinoStorage, and HoodieStorageUtils.getStorage resolves that class
reflectively through a (StoragePath, StorageConfiguration) constructor, which
HudiTrinoStorage did not provide. Every hudi-common code path that resolves
storage from configuration therefore fails in the Trino runtime with "Unable to
create HudiTrinoStorage".
Nothing had exercised it. The read path never uses config-based resolution:
it constructs HudiTrinoStorage directly with the session's TrinoFileSystem and
passes the object in via setStorage, and TableStatisticsReader likewise passes
metaClient.getStorage() explicitly. Every existing production initTable caller
is Spark or Hadoop based and resolves to HoodieHadoopStorage, which does
provide the constructor, so Trino is the first non-Hadoop writer to reach this
path.
Adds the required constructor. Because it receives only a configuration, and
a TrinoFileSystem is session-scoped and not reconstructible from configuration
properties, TrinoStorageConfiguration now carries the session's filesystem and
the new constructor retrieves it, within a single synchronous call stack and
with no ThreadLocal or static state. newInstance() carries it across so derived
configurations can still resolve storage.
The change is additive: no existing constructor, method or call site is
modified, and the path being fixed currently fails unconditionally, so there is
no working behaviour to regress. Contained in hudi-trino, verified against an
unmodified hudi-common.
### Describe the issue this Pull Request addresses
<!-- Either describe the issue inline here with motivation behind the
changes
(or) link to an issue by including `Closes #<issue-number>` for
context.
If this PR includes changes to the storage format, public APIs,
or has breaking changes, use `!` (e.g., feat!: ...) -->
### Summary and Changelog
<!-- Short, plain-English summary of what users gain or what changed in
behavior.
Followed by a detailed log of all the changes. Highlight if any code
was copied. -->
### Impact
<!-- Describe any public API or user-facing feature change or any
performance impact. -->
### Risk Level
<!-- Accepted values: none, low, medium or high. Other than `none`, explain
the risk.
If medium or high, explain what verification was done to mitigate the
risks. -->
### Documentation Update
<!-- Describe any necessary documentation update if there is any new
feature, config, or user-facing change. If not, put "none".
- The config description must be updated if new configs are added or the
default value of the configs are changed.
- Any new feature or user-facing change requires updating the Hudi website.
Please follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website)
to make changes to the website. -->
### Contributor's checklist
- [ ] Read through [contributor's
guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
