hudi-agent commented on code in PR #19882:
URL: https://github.com/apache/hudi/pull/19882#discussion_r3972548082
##########
hudi-trino/src/main/java/io/trino/plugin/hudi/storage/HudiTrinoStorage.java:
##########
@@ -54,6 +54,25 @@ public HudiTrinoStorage(TrinoFileSystem fileSystem,
TrinoStorageConfiguration st
this.fileSystem = fileSystem;
}
+ public HudiTrinoStorage(StoragePath path, StorageConfiguration<?>
storageConf)
+ {
+ this(fileSystemOf(storageConf, path),
trinoConfigurationOf(storageConf, path));
+ }
+
+ private static TrinoStorageConfiguration
trinoConfigurationOf(StorageConfiguration<?> storageConf, StoragePath path)
+ {
Review Comment:
🤖 nit: fileSystemOf calls trinoConfigurationOf again, so the constructor
casts storageConf twice - might be simpler to resolve the
TrinoStorageConfiguration once in the constructor and pass it to both, or just
inline the file-system lookup.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
