hudi-agent commented on code in PR #19882:
URL: https://github.com/apache/hudi/pull/19882#discussion_r3967755668
##########
hudi-trino/src/main/java/io/trino/plugin/hudi/storage/TrinoStorageConfiguration.java:
##########
@@ -28,14 +30,32 @@ public class TrinoStorageConfiguration
{
private final Map<String, String> configMap;
+ private final transient TrinoFileSystem fileSystem;
+
public TrinoStorageConfiguration()
{
- this(getDefaultConfigs());
+ this(getDefaultConfigs(), null);
+ }
+
+ public TrinoStorageConfiguration(TrinoFileSystem fileSystem)
Review Comment:
🤖 The production call sites (`HudiUtil.buildTableMetaClient`,
`TableStatisticsReader`) still build `new TrinoStorageConfiguration()` without
the file system, so e.g. `metaClient.getStorage(somePath)` or
`HoodieTableMetadataUtil.metadataPartitionExists(..., engineContext, ...)` from
the connector would still fail (now with the clearer "carries no file system"
message). Was leaving those as-is intentional for this PR, or would it make
sense to pass the session `TrinoFileSystem` through there too so the extension
point is actually reachable from the read path?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
