wombatu-kun commented on code in PR #19875:
URL: https://github.com/apache/hudi/pull/19875#discussion_r3975869698
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieDropPartitionsTool.java:
##########
@@ -244,7 +244,7 @@ public boolean equals(Object o) {
return false;
}
Config config = (Config) o;
- return basePath.equals(config.basePath)
+ return Objects.equals(basePath, config.basePath)
Review Comment:
`HoodieDropPartitionsTool.Config.hashCode` and
`TableSizeStats.Config.hashCode` still fold in `help` while neither `equals`
compares it, so two configs differing only in `--help` are equal with different
hash codes. Dropping `help` from both `Objects.hash` calls, plus the
`askedForHelp` case the two validator tests now carry, would close it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
