voonhous commented on code in PR #19875:
URL: https://github.com/apache/hudi/pull/19875#discussion_r3975963020
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieDropPartitionsTool.java:
##########
@@ -244,7 +244,7 @@ public boolean equals(Object o) {
return false;
}
Config config = (Config) o;
- return basePath.equals(config.basePath)
+ return Objects.equals(basePath, config.basePath)
Review Comment:
Done: `help` is out of both `Objects.hash` calls and both contract tests
carry the `askedForHelp` case, which fails on the old hash codes. With this,
every `Config` this PR touches has `equals` and `hashCode` over the same
fields. Done in a8264e1fcba0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
