ashokraminedi opened a new pull request, #20043:
URL: https://github.com/apache/hudi/pull/20043

   ### Describe the issue this Pull Request addresses
   
   Closes #20004.
   
   `hudi-trino` includes a `HudiPlugin` class that Trino does not load. Trino 
has its own plugin entry point with the same class name, so including both 
classes creates a duplicate in the plugin’s dependencies.
   
   ### Summary and Changelog
   
   Moved Hudi’s `HudiPlugin` from main sources to test sources and renamed it 
`HudiTestPlugin`. Updated the tests that use it, including `TestingHudiPlugin`.
   
   The published `hudi-trino` jar still contains `HudiConnectorFactory`, which 
Trino’s plugin uses. I checked the built jar and confirmed it contains neither 
`HudiPlugin` nor `HudiTestPlugin`.
   
   ### Impact
   
   This removes the duplicate class from Hudi’s published jar. Connector 
behavior, configuration, storage format, and performance are unchanged. Code 
that directly instantiates `HudiPlugin` from the Hudi jar would need to provide 
its own plugin wrapper.
   
   ### Risk Level
   
   Low. The test-only plugin retains the existing implementation, and the test 
callers have been updated. The full `hudi-trino` test suite completed with 847 
tests reported, 0 failures, 0 errors, and 179 skipped.
   
   ### Documentation Update
   
   None. There are no new features or configuration changes.
   
   - The config description must be updated if new configs are added or the 
default value of the configs are changed.
   - Any new feature or user-facing change requires updating the Hudi website. 
Please follow the 
     [instruction](https://hudi.apache.org/contribute/developer-setup#website) 
to make changes to the website. -->
   
   ### Contributor's checklist
   
   - [X] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [X] Enough context is provided in the sections above
   - [X] Adequate tests were added if applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to