voonhous commented on code in PR #20043: URL: https://github.com/apache/hudi/pull/20043#discussion_r4100563444
########## hudi-trino/src/test/java/io/trino/plugin/hudi/TestingHudiPlugin.java: ########## @@ -14,30 +14,35 @@ package io.trino.plugin.hudi; import com.google.common.collect.ImmutableList; +import io.trino.spi.Plugin; import io.trino.spi.connector.ConnectorFactory; import java.nio.file.Path; -import java.util.List; +import java.util.Optional; -import static com.google.common.base.Verify.verify; import static java.util.Objects.requireNonNull; public class TestingHudiPlugin Review Comment: This is a test-only plugin for installing the Hudi connector into a query runner. The production code `HudiPlugin` lives in Trino's code base as per RFC-105. The constructor installs the production `HudiConnectorFactory` that is backed by a local fs rooted at the given path. No action needed from your end. Just leaving it here since it's not part of an inline comment so we have something to refer to when trying to understand why this piece of code is here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
