voonhous commented on PR #20043: URL: https://github.com/apache/hudi/pull/20043#issuecomment-5813688757
@ashokraminedi Hello, appreciate the fix, but the issue calls to remove `HudiPlugin`, not to replace it with another class. I understand that your goal is to retain the tests. IIRC, `TestHudiConnectorFactory` already tests the same things, and more thoroughly. Should we just outright remove the class so as to reduce code-hoarding? I have a fix for things here: https://github.com/voonhous/hudi/commit/48672e936464453e1d93c3a302a618c8d7002a3e#diff-024c07b1e8563f8f722e6365d8b223a7b5f2548a7077c28433cde29da3fcf78f I have yet to raise a PR, we can keep your PR where you take reference from the above and make the changes accordingly? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
