ssdong commented on a change in pull request #2784: URL: https://github.com/apache/hudi/pull/2784#discussion_r610256593
########## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/MetadataConversionUtils.java ########## @@ -72,9 +76,14 @@ public static HoodieArchivedMetaEntry createMetaWrapper(HoodieInstant hoodieInst HoodieReplaceCommitMetadata replaceCommitMetadata = HoodieReplaceCommitMetadata .fromBytes(metaClient.getActiveTimeline().getInstantDetails(hoodieInstant).get(), HoodieReplaceCommitMetadata.class); archivedMetaWrapper.setHoodieReplaceCommitMetadata(ReplaceArchivalHelper.convertReplaceCommitMetadata(replaceCommitMetadata)); + } else if (hoodieInstant.isInflight()) { + // inflight replacecommit files have the same meta data body as HoodieCommitMetadata Review comment: Hey @satishkotha The `inflight` was _originally_ empty in the unit tests before I _change_ it to have meta body in it. I wasn’t seeing the whole picture that `inflight` could be both empty and non-empty, neither were the original unit tests covering both cases. We are working on giving it a little refactoring to have the tests covering both ends. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org