ssdong commented on a change in pull request #2784:
URL: https://github.com/apache/hudi/pull/2784#discussion_r610259030
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/MetadataConversionUtils.java
##########
@@ -72,9 +76,14 @@ public static HoodieArchivedMetaEntry
createMetaWrapper(HoodieInstant hoodieInst
HoodieReplaceCommitMetadata replaceCommitMetadata =
HoodieReplaceCommitMetadata
.fromBytes(metaClient.getActiveTimeline().getInstantDetails(hoodieInstant).get(),
HoodieReplaceCommitMetadata.class);
archivedMetaWrapper.setHoodieReplaceCommitMetadata(ReplaceArchivalHelper.convertReplaceCommitMetadata(replaceCommitMetadata));
+ } else if (hoodieInstant.isInflight()) {
+ // inflight replacecommit files have the same meta data body as
HoodieCommitMetadata
Review comment:
Also, the current unit tests set meta for `requested` commit files which
isn’t _strictly_ following and reflecting the actual behavior(we have empty
requested file). I believe down the roadmap, we will have to standardize the
requested file structure and investigate why it’s empty. There is a jira ticket
filed for that and we have self-assigned and will work on that next. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
