ssdong commented on pull request #2784: URL: https://github.com/apache/hudi/pull/2784#issuecomment-817174595
Hi @satishkotha, I've updated the PR to reflect the most up-to-date conversations regarding handling different scenarios of requested and inflight cases for insert_overwrite and clustering, and I've placed adequate comments to try not to confuse anyone who reads code, as it had confused me before. Also, I updated the PR description to attach the testing evidence from local. Please take a look. Unit tests have also been updated to cover both cases, and I did some trivial refactoring, e.g. remove unused methods. Let me know if there is anything else we should be doing in this PR. Otherwise, it's in a good state to be reviewed again. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
