wangxianghu commented on a change in pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#discussion_r662307168
##########
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/keygen/factory/HoodieSparkKeyGeneratorFactory.java
##########
@@ -54,7 +59,12 @@ public static KeyGenerator
createKeyGenerator(TypedProperties props) throws IOEx
private static BuiltinKeyGenerator createKeyGeneratorByType(TypedProperties
props) throws IOException {
// Use KeyGeneratorType.SIMPLE as default keyGeneratorType
String keyGeneratorType =
- props.getString(HoodieWriteConfig.KEYGENERATOR_TYPE_PROP.key(),
KeyGeneratorType.SIMPLE.name());
Review comment:
> Why do we need to refactor this? For adding a log message?
Yes, to remind the user that they didn't set the key config, hudi use the
default one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
