wangxianghu commented on a change in pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#discussion_r662308139
##########
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/bootstrap/SparkBootstrapCommitActionExecutor.java
##########
@@ -390,8 +390,15 @@ private BootstrapWriteStatus
handleMetadataBootstrap(String srcPartitionPath, St
TypedProperties properties = new TypedProperties();
properties.putAll(config.getProps());
- KeyGeneratorInterface keyGenerator = (KeyGeneratorInterface)
ReflectionUtils.loadClass(config.getBootstrapKeyGeneratorClass(),
- properties);
+
+ KeyGeneratorInterface keyGenerator;
+ try {
+ keyGenerator =
HoodieSparkKeyGeneratorFactory.createKeyGenerator(properties);
+ } catch (IOException e) {
+ LOG.error("Init keyGenerator failed ", e);
Review comment:
> Since we have thrown an exception, we may not need to add a log.
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
