wangxianghu commented on a change in pull request #3170:
URL: https://github.com/apache/hudi/pull/3170#discussion_r662308773
##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java
##########
@@ -353,14 +354,20 @@ private static int
deduplicatePartitionPath(JavaSparkContext jsc, String duplica
private static int doBootstrap(JavaSparkContext jsc, String tableName,
String tableType, String basePath,
String sourcePath, String recordKeyCols, String partitionFields, String
parallelism, String schemaProviderClass,
- String bootstrapIndexClass, String selectorClass, String
keyGeneratorClass, String fullBootstrapInputProvider,
+ String bootstrapIndexClass, String selectorClass, String keyGenerator,
String fullBootstrapInputProvider,
String payloadClassName, String enableHiveSync, String propsFilePath,
List<String> configs) throws IOException {
TypedProperties properties = propsFilePath == null ?
UtilHelpers.buildProperties(configs)
: UtilHelpers.readConfig(FSUtils.getFs(propsFilePath,
jsc.hadoopConfiguration()), new Path(propsFilePath), configs).getConfig();
properties.setProperty(HoodieBootstrapConfig.BOOTSTRAP_BASE_PATH_PROP.key(),
sourcePath);
- properties.setProperty(HoodieBootstrapConfig.BOOTSTRAP_KEYGEN_CLASS.key(),
keyGeneratorClass);
+
+ if (KeyGeneratorType.getNames().contains(keyGenerator)) {
Review comment:
> it should be `contains` or `equals` or `equals ignore case sensitive`？
This `getNames()` returns a list, should use `contains`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
