[
https://issues.apache.org/jira/browse/HUDI-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376997#comment-17376997
]
ASF GitHub Bot commented on HUDI-1860:
--------------------------------------
vinothchandar commented on a change in pull request #3184:
URL: https://github.com/apache/hudi/pull/3184#discussion_r665838584
##########
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/SparkRDDWriteClient.java
##########
@@ -200,7 +200,8 @@ public HoodieWriteResult
insertOverwrite(JavaRDD<HoodieRecord<T>> records, final
table.validateInsertSchema();
preWrite(instantTime, WriteOperationType.INSERT_OVERWRITE,
table.getMetaClient());
HoodieWriteMetadata result = table.insertOverwrite(context, instantTime,
records);
- return new HoodieWriteResult(postWrite(result, instantTime, table),
result.getPartitionToReplaceFileIds());
+ return new HoodieWriteResult(postWrite(result, instantTime, table),
Review comment:
Would be good to avoiid unrelated cosmetic changes and do them
separately :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Add INSERT_OVERWRITE support to DeltaStreamer
> ---------------------------------------------
>
> Key: HUDI-1860
> URL: https://issues.apache.org/jira/browse/HUDI-1860
> Project: Apache Hudi
> Issue Type: Sub-task
> Reporter: Sagar Sumit
> Assignee: Samrat Deb
> Priority: Major
> Labels: pull-request-available
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> As discussed in [this
> RFC|https://cwiki.apache.org/confluence/display/HUDI/RFC+-+14+%3A+JDBC+incremental+puller],
> having full fetch mode use the inser_overwrite to write to sync would be
> better as it can handle schema changes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
