[
https://issues.apache.org/jira/browse/HUDI-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377826#comment-17377826
]
ASF GitHub Bot commented on HUDI-1860:
--------------------------------------
codope commented on a change in pull request #3184:
URL: https://github.com/apache/hudi/pull/3184#discussion_r666687005
##########
File path:
hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/HoodieDeltaStreamerWrapper.java
##########
@@ -53,14 +54,37 @@ public HoodieDeltaStreamerWrapper(Config cfg,
JavaSparkContext jssc) throws Exce
return upsert(WriteOperationType.BULK_INSERT);
}
+ public JavaRDD<WriteStatus> insertOverwrite() throws
+ Exception {
+ return insertOverwrite(WriteOperationType.INSERT_OVERWRITE);
+ }
+
+ public JavaRDD<WriteStatus> insertOverwrite(WriteOperationType operation)
throws Exception {
+ cfg.operation = operation;
+ return deltaSyncService.get().getDeltaSync().syncOnce().getRight();
+ }
+
+ public JavaRDD<WriteStatus> insertOverwriteTable() throws
+ Exception {
+ return insertOverwriteTable(WriteOperationType.INSERT_OVERWRITE_TABLE);
+ }
+
+ public JavaRDD<WriteStatus> insertOverwriteTable(WriteOperationType
operation) throws
Review comment:
Instead of new method, can we not reuse `insertOverwrite()` method in
line 62? Note that these wrapper methods are only used for integration test
suite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Add INSERT_OVERWRITE support to DeltaStreamer
> ---------------------------------------------
>
> Key: HUDI-1860
> URL: https://issues.apache.org/jira/browse/HUDI-1860
> Project: Apache Hudi
> Issue Type: Sub-task
> Reporter: Sagar Sumit
> Assignee: Samrat Deb
> Priority: Major
> Labels: pull-request-available
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> As discussed in [this
> RFC|https://cwiki.apache.org/confluence/display/HUDI/RFC+-+14+%3A+JDBC+incremental+puller],
> having full fetch mode use the inser_overwrite to write to sync would be
> better as it can handle schema changes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
