yihua commented on a change in pull request #3233:
URL: https://github.com/apache/hudi/pull/3233#discussion_r671078609
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/view/HoodieTableFileSystemView.java
##########
@@ -361,4 +361,24 @@ public void close() {
public boolean isClosed() {
return closed;
}
+
+ @Override
+ public Set<String> getAllMarkerFilePaths(String markerDirPath) {
Review comment:
Javadocs added.
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/view/TableFileSystemView.java
##########
@@ -185,4 +186,12 @@
* Filegroups that are in pending clustering.
*/
Stream<Pair<HoodieFileGroupId, HoodieInstant>>
getFileGroupsInPendingClustering();
+
+ Set<String> getAllMarkerFilePaths(String markerDirPath);
Review comment:
Javadocs added.
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/view/RocksDbBasedFileSystemView.java
##########
@@ -511,4 +511,24 @@ public void close() {
boolean isClosed() {
return closed;
}
+
+ @Override
+ public Set<String> getAllMarkerFilePaths(String markerDirPath) {
Review comment:
Here are the classes I change:
```
HoodieTableFileSystemView -> IncrementalTimelineSyncFileSystemView ->
AbstractTableFileSystemView -> SyncableFileSystemView (interface) ->
TableFileSystemView (interface)
PriorityBasedFileSystemView -> SyncableFileSystemView (interface) ->
TableFileSystemView (interface)
RemoteHoodieTableFileSystemView -> SyncableFileSystemView (interface) ->
TableFileSystemView (interface)
RocksDbBasedFileSystemView -> IncrementalTimelineSyncFileSystemView ->
AbstractTableFileSystemView -> SyncableFileSystemView (interface) ->
TableFileSystemView (interface)
```
I've simplified the change to avoid redundancy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
