yihua commented on a change in pull request #3233:
URL: https://github.com/apache/hudi/pull/3233#discussion_r674373226



##########
File path: 
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##########
@@ -423,7 +424,8 @@ protected void preWrite(String instantTime, 
WriteOperationType writeOperationTyp
   protected void postCommit(HoodieTable<T, I, K, O> table, 
HoodieCommitMetadata metadata, String instantTime, Option<Map<String, String>> 
extraMetadata) {
     try {
       // Delete the marker directory for the instant.
-      new MarkerFiles(table, instantTime).quietDeleteMarkerDir(context, 
config.getMarkersDeleteParallelism());
+      MarkerFilesFactory.get(config.getMarkersIOMode(), table, instantTime)

Review comment:
       Right.  I think the upgrade/downgrade functionality can be added in a 
follow-up PR if we'd like to merge this soon.  I'll work on that.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to