yihua commented on a change in pull request #3233:
URL: https://github.com/apache/hudi/pull/3233#discussion_r674370725
##########
File path:
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/rollback/TestCopyOnWriteRollbackActionExecutor.java
##########
@@ -213,6 +213,6 @@ private void performRollbackAndValidate(boolean
isUsingMarkers, HoodieWriteConfi
String.format("%s:%s/%s", this.fs.getScheme(), basePath,
rollbackMetadata.get(DEFAULT_SECOND_PARTITION_PATH).getSuccessDeleteFiles().get(0)));
}
- assertFalse(new MarkerFiles(table,
commitInstant.getTimestamp()).doesMarkerDirExist());
+ assertFalse(new DirectMarkerFiles(table,
commitInstant.getTimestamp()).doesMarkerDirExist());
Review comment:
Yes, I'm working on making marker related unit tests parameterized so we
can cover both strategies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
