[
https://issues.apache.org/jira/browse/HUDI-2315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401376#comment-17401376
]
ASF GitHub Bot commented on HUDI-2315:
--------------------------------------
umehrot2 commented on a change in pull request #3491:
URL: https://github.com/apache/hudi/pull/3491#discussion_r691600177
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java
##########
@@ -339,32 +339,134 @@ public HoodieFileFormat getBaseFileFormat() {
* @return HoodieFileFormat for the log Storage format
*/
public HoodieFileFormat getLogFileFormat() {
- return
HoodieFileFormat.valueOf(getStringOrDefault(HOODIE_LOG_FILE_FORMAT_PROP));
+ return HoodieFileFormat.valueOf(getStringOrDefault(LOG_FILE_FORMAT));
}
/**
* Get the relative path of archive log folder under metafolder, for this
table.
*/
public String getArchivelogFolder() {
- return getStringOrDefault(HOODIE_ARCHIVELOG_FOLDER_PROP);
+ return getStringOrDefault(ARCHIVELOG_FOLDER);
}
/**
* @returns true is meta fields need to be populated. else returns false.
*/
public boolean populateMetaFields() {
- return
Boolean.parseBoolean(getStringOrDefault(HOODIE_POPULATE_META_FIELDS));
+ return Boolean.parseBoolean(getStringOrDefault(POPULATE_META_FIELDS));
}
/**
* @returns the record key field prop.
*/
public String getRecordKeyFieldProp() {
- return getString(HOODIE_TABLE_RECORDKEY_FIELDS);
+ return getString(RECORDKEY_FIELDS);
}
public Map<String, String> propsMap() {
return props.entrySet().stream()
.collect(Collectors.toMap(e -> String.valueOf(e.getKey()), e ->
String.valueOf(e.getValue())));
}
+
+
Review comment:
nit: extra line
##########
File path:
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala
##########
@@ -243,7 +243,7 @@ object DataSourceWriteOptions {
* Payload class used. Override this, if you like to roll your own merge
logic, when upserting/inserting.
Review comment:
Should we rename `DataSourceOptions.TABLE_NAME` to `TBL_NAME` to keep
consistency with `HoodieWriteConfig.TBL_NAME` ?
##########
File path:
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/testutils/HoodieClientTestHarness.java
##########
@@ -64,13 +64,15 @@
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
+import scala.Tuple2;
+
Review comment:
Remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Maintain compatibility with pre Hudi 0.9.0 config keys, while marking them as
> deprecated
> ----------------------------------------------------------------------------------------
>
> Key: HUDI-2315
> URL: https://issues.apache.org/jira/browse/HUDI-2315
> Project: Apache Hudi
> Issue Type: Sub-task
> Reporter: Udit Mehrotra
> Assignee: Vinoth Chandar
> Priority: Blocker
> Labels: pull-request-available, release-blocker
> Fix For: 0.9.0
>
>
> With introduced a new configuration framework in HUDI-89, where all the
> String configurations have been replaced with ConfigProperty structure.
> However, we still want to maintain compatibility with existing pre Hudi 0.9.0
> config keys, so that it does not break existing users. At the same time, we
> will mark the previous config keys as deprecated so users can start migrating
> to the new configs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
