[
https://issues.apache.org/jira/browse/HUDI-2315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401569#comment-17401569
]
ASF GitHub Bot commented on HUDI-2315:
--------------------------------------
umehrot2 commented on pull request #3491:
URL: https://github.com/apache/hudi/pull/3491#issuecomment-901756554
> @umehrot2 Thanks for the additional fix!
> One thing I noticed is that the
`DataSourceWriteOptions.KEYGENERATOR_CLASS` has a default value but
`HoodieWriteConfig.KEYGENERATOR_CLASS` doesn't. I think we should have the same
default values at both places if it's not intentional.
@codope good catch. I checked the history, and seems like it was done
intentionally https://github.com/apache/hudi/pull/2993#discussion_r642188609 .
@nsivabalan can confirm since he reviewed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Maintain compatibility with pre Hudi 0.9.0 config keys, while marking them as
> deprecated
> ----------------------------------------------------------------------------------------
>
> Key: HUDI-2315
> URL: https://issues.apache.org/jira/browse/HUDI-2315
> Project: Apache Hudi
> Issue Type: Sub-task
> Reporter: Udit Mehrotra
> Assignee: Vinoth Chandar
> Priority: Blocker
> Labels: pull-request-available, release-blocker
> Fix For: 0.9.0
>
>
> With introduced a new configuration framework in HUDI-89, where all the
> String configurations have been replaced with ConfigProperty structure.
> However, we still want to maintain compatibility with existing pre Hudi 0.9.0
> config keys, so that it does not break existing users. At the same time, we
> will mark the previous config keys as deprecated so users can start migrating
> to the new configs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
