[
https://issues.apache.org/jira/browse/HUDI-2315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401379#comment-17401379
]
ASF GitHub Bot commented on HUDI-2315:
--------------------------------------
vinothchandar commented on a change in pull request #3491:
URL: https://github.com/apache/hudi/pull/3491#discussion_r691626939
##########
File path:
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala
##########
@@ -243,7 +243,7 @@ object DataSourceWriteOptions {
* Payload class used. Override this, if you like to roll your own merge
logic, when upserting/inserting.
Review comment:
HoodieTableConfig.NAME is what its called in another place. Most users
set it via DataSourceOptions? So should be fine leaving it more descriptive
like that TABLE_NAME
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Maintain compatibility with pre Hudi 0.9.0 config keys, while marking them as
> deprecated
> ----------------------------------------------------------------------------------------
>
> Key: HUDI-2315
> URL: https://issues.apache.org/jira/browse/HUDI-2315
> Project: Apache Hudi
> Issue Type: Sub-task
> Reporter: Udit Mehrotra
> Assignee: Vinoth Chandar
> Priority: Blocker
> Labels: pull-request-available, release-blocker
> Fix For: 0.9.0
>
>
> With introduced a new configuration framework in HUDI-89, where all the
> String configurations have been replaced with ConfigProperty structure.
> However, we still want to maintain compatibility with existing pre Hudi 0.9.0
> config keys, so that it does not break existing users. At the same time, we
> will mark the previous config keys as deprecated so users can start migrating
> to the new configs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
