Svecco commented on code in PR #2452:
URL: https://github.com/apache/iggy/pull/2452#discussion_r2656212590
##########
core/server/src/configs/defaults.rs:
##########
@@ -403,6 +403,8 @@ impl Default for LoggingConfig {
level: SERVER_CONFIG.system.logging.level.parse().unwrap(),
file_enabled: SERVER_CONFIG.system.logging.file_enabled,
max_size: SERVER_CONFIG.system.logging.max_size.parse().unwrap(),
+ max_total_size:
SERVER_CONFIG.system.logging.max_total_size.parse().unwrap(),
+ rotation_check_interval:
SERVER_CONFIG.system.logging.rotation_check_interval as u64,
Review Comment:
> (see `validators.rs`)
I have added checks that cover certain special cases, such as an excessively
high check frequency, among other scenarios.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
