Svecco commented on code in PR #2452:
URL: https://github.com/apache/iggy/pull/2452#discussion_r2656214765
##########
core/server/src/configs/system.rs:
##########
@@ -88,12 +88,26 @@ pub struct LoggingConfig {
pub level: String,
pub file_enabled: bool,
pub max_size: IggyByteSize,
+ #[serde(default = "default_max_total_log_size")]
+ pub max_total_size: IggyByteSize,
+ #[serde(default = "default_log_rotation_check_interval")]
+ pub rotation_check_interval: u64,
Review Comment:
Done, and now there are:
```rust
#[serde_as]
#[derive(Debug, Deserialize, Serialize)]
pub struct LoggingConfig {
pub path: String,
pub level: String,
pub file_enabled: bool,
pub max_file_size: IggyByteSize,
pub max_total_size: IggyByteSize,
#[serde_as(as = "DisplayFromStr")]
pub rotation_check_interval: IggyDuration,
#[serde_as(as = "DisplayFromStr")]
pub retention: IggyDuration,
#[serde_as(as = "DisplayFromStr")]
pub sysinfo_print_interval: IggyDuration,
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
