krishvishal commented on code in PR #2675:
URL: https://github.com/apache/iggy/pull/2675#discussion_r2798903104
##########
core/metadata/src/stm/consumer_group.rs:
##########
@@ -225,3 +227,150 @@ impl Handler for ConsumerGroupsInner {
}
}
}
+
+/// Consumer group member snapshot representation for serialization.
+#[derive(Debug, Clone, Serialize, Deserialize)]
Review Comment:
Structs that are stored inside Arc, Atomic variables are not serializeable.
```rust
pub struct Stream {
pub id: usize,
pub name: Arc<str>,
pub created_at: IggyTimestamp,
pub stats: Arc<StreamStats>, ///- not serializeable
pub topics: Slab<Topic>, ///- Topic is not serializeable
pub topic_index: AHashMap<Arc<str>, usize>,
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
