krishvishal commented on code in PR #2675:
URL: https://github.com/apache/iggy/pull/2675#discussion_r2798993889


##########
core/metadata/src/stm/consumer_group.rs:
##########
@@ -225,3 +227,150 @@ impl Handler for ConsumerGroupsInner {
         }
     }
 }
+
+/// Consumer group member snapshot representation for serialization.
+#[derive(Debug, Clone, Serialize, Deserialize)]

Review Comment:
   Yes, we have to manually impl Serialize for everything that's not 
serializeable. The intermediate struct approach felt more cleaner although 
seems like more work. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to