krishvishal commented on code in PR #2675:
URL: https://github.com/apache/iggy/pull/2675#discussion_r2801064214
##########
core/metadata/src/stm/consumer_group.rs:
##########
@@ -225,3 +227,150 @@ impl Handler for ConsumerGroupsInner {
}
}
}
+
+/// Consumer group member snapshot representation for serialization.
+#[derive(Debug, Clone, Serialize, Deserialize)]
Review Comment:
`rc` is only useful for `Arc`. And also I feel handling `Arc<TopicStats>` in
`Topic` is complicated. Because each topic shares the same `TopicStats` that we
have skip the deserialization step for it.
Currently I don't see how we can straightforwardly impl custom
Serialize/Deserialize and get everything working without handling things like
`Arc<TopicStats>`. I feel this will become even more complicated than the
current solution. I maybe wrong here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
