mfyuce commented on PR #3516: URL: https://github.com/apache/iggy/pull/3516#issuecomment-4763143938
Good catch @ryerraguntla — fixed in the latest push. **Root cause:** `tokio::spawn(run_grpc_server(addr, ...))` returned immediately; if bind failed, the server task exited silently, `tx` was dropped, and `poll()` returned `Ok(empty)` forever at CPU speed with connector status stuck at `Running`. **Fix:** `TcpIncoming::bind(addr)` is called synchronously in `open()` *before* `tokio::spawn`. Any bind failure (`EADDRINUSE`, `EPERM`, …) now propagates as `Error::InitError` from `open()`, which surfaces in the connector lifecycle and stops the source cleanly. `run_grpc_server` now takes the pre-bound `TcpIncoming` and uses `serve_with_incoming_shutdown`. /ready -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
